[PATCH] D29104: Add !associated metadata.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:243-244
+    UniqueID = NextUniqueID++;
+    Flags |= ELF::SHF_LINK_ORDER;
+    AssociatedSymbol = getAssociatedSymbol(MD, TM);
+  }
----------------
I think you need to make sure AssociatedSymbol is non-null before setting the flag. Please also add a negative test for a non-GlobalObject constant.


================
Comment at: lib/CodeGen/TargetLoweringObjectFileImpl.cpp:366-367
+    EmitUniqueSection = true;
+    Flags |= ELF::SHF_LINK_ORDER;
+    AssociatedSymbol = getAssociatedSymbol(MD, TM);
+  }
----------------
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D29104