[PATCH] D29862: LSR: an alternative way to resolve complex solution

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 16:26:24 PST 2017


evstupac added a comment.

> 1. Should we set the option to true by default? I believe it would be best to keep it to false and send an email to llvm-dev to ask for benchmarking.
> 2. The floating point thingy that I mentioned.
> 
> I am fine with moving forward with the current patch as long as you commit to look at #2.

Thanks, Quentin.
I'm OOO next week. Committing the patch as is is the best option for me to get some feedback during my OOO.
I'll commit it with the option set to "false" by default.
It was set true in the review for 2 reasons: testing (if someone download patch as is) and to show influence on LIT tests.
And I will not make the option true until a decision on #2. I'll look into it once I'm back.

Thanks,
Evgeny


Repository:
  rL LLVM

https://reviews.llvm.org/D29862





More information about the llvm-commits mailing list