[PATCH] D29998: Add initial support for debug counting

Michael Spencer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 15:33:38 PST 2017


Bigcheese added inline comments.


================
Comment at: lib/Support/DebugCounter.cpp:19
+  template <class... Mods>
+  explicit DebugCounterList(const Mods &... Ms) : Base(Ms...) {}
+
----------------
I believe this should be:


```
explicit DebugCounterList(Mods &&... Ms) : Base(std::forward<Mods>(Ms)...) {}
```

Which is the idiomatic way to forward arguments.


https://reviews.llvm.org/D29998





More information about the llvm-commits mailing list