[PATCH] D30085: [LLD][ELF] Alloc local symbols to be added to the SymTab after global symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 10:14:23 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:1091
+  if (!StrTabSec.isDynamic()) {
+    // All explictly added STB_LOCAL symbols without a Symbol are first
+    auto It = std::stable_partition(
----------------
Please mention that that's required by the ELF standard.


https://reviews.llvm.org/D30085





More information about the llvm-commits mailing list