[PATCH] D30089: [globalisel][tblgen] Add support for ComplexPatterns

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 17 09:28:37 PST 2017


qcolombet added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:1240
+  unsigned ShVal = AArch64_AM::getShifterImm(AArch64_AM::LSL, ShiftAmt);
+  Result1 = MachineOperand::CreateImm(Immed);
+  Result2 = MachineOperand::CreateImm(ShVal);
----------------
Can't we modify the existing placeholder instead of creating a temporary object and then use the copy constructor?


https://reviews.llvm.org/D30089





More information about the llvm-commits mailing list