[PATCH] D29670: [DebugInfo] Emit address space with DW_AT_address_class attribute for pointer and reference types

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: test/Bitcode/pointer-address-space.ll:5
+; CHECK-DAG: ![[LOCAL:[0-9]+]] = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}}, addressSpace: 2)
+; CHECK-DAG: ![[PRIVATE:[0-9]+]] = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !{{[0-9]+}}, size: {{[0-9]+}}, addressSpace: 1)
+
----------------
The point of the bitcode test is to ensure that the bitcode upgrade from an *older* version (without the address space field, i.e., today's LLVM trunk) is handled correctly. The IR assembler round-trip tests are already testing that the *current* bitcode is handled correctly.

The fact that this test is checking for `addressSpace: 2` makes it look like the .bc file was generated with this patch and not with current LLVM trunk?


https://reviews.llvm.org/D29670