[PATCH] D30049: x86 interrupt calling convention: re-align stack pointer on 64-bit if an error code was pushed

[David Kreitzer via Phabricator via llvm-commits]

DavidKreitzer added a comment.

Aligning the stack is certainly the right thing to do. But this isn't the only problem with 26413 <https://bugs.llvm.org//show_bug.cgi?id=26477>. I will add a note to the report explaining what I mean.

As far as I am concerned, this patch looks good, but I would like someone else to comment on whether this is best mechanism for accomplishing the desired stack alignment.

Thanks,
Dave



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:3117
+    // X86 interrupts must pop the error code (and the alignment padding)
+    // if present
+    FuncInfo->setBytesToPopOnReturn(Is64Bit ? 16 : 4);
----------------
Please add a '.' here.


https://reviews.llvm.org/D30049