[PATCH] D29671: [DebugInfo] Add address space when creating DIDerivedTypes

[Tony Tye via Phabricator via llvm-commits]

tony-tye added inline comments.


================
Comment at: include/clang/Basic/TargetInfo.h:1040-1041
+
+  /// \returns Target-specific DWARF address space that is equivalent to given
+  /// \p AddressSpace.
+  virtual Optional<unsigned> getDWARFAddressSpace(unsigned AddressSpace) const {
----------------
Perhaps give a more detailed description:

"\return If a target requires an address within a target specific address space \p AddressSpace to be converted in order to be used, then return the corresponding target specific DWARF address space.
\return Otherwise return None and no conversion will be emitted in the DWARF."


================
Comment at: lib/Basic/Targets.cpp:2259-2260
+
+  /// \returns Target-specific DWARF address space that is equivalent to given
+  /// \p AddressSpace.
+  Optional<unsigned> getDWARFAddressSpace(
----------------
Same comment as above.


https://reviews.llvm.org/D29671