[PATCH] D30053: Add function importing info from samplepgo profile to the module summary.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 17:32:29 PST 2017


danielcdh added a comment.

In https://reviews.llvm.org/D30053#679264, @davidxl wrote:

> Is it better to introduce a new meta data for this, e.g. MD_inline_instance_imports ?


I'm fine with that. But the function definition only allows one !prof metadata. So MD_inline_instance_imports can not use !prof, what should it use?

> Can this information be directly communicated to function importer instead of relying on modifying Callgraph/profile data?

It needs to be part of module summary. I suppose function importer cannot have access to IR?


https://reviews.llvm.org/D30053





More information about the llvm-commits mailing list