[PATCH] D29807: FileCheck-ize some tests in test/CodeGen/X86/

Jorge Gorbe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 16:19:28 PST 2017


jgorbe added inline comments.


================
Comment at: test/CodeGen/X86/2005-01-17-CycleInDAG.ll:18
+  ret i32 %Z
+; CHECK-NOT: {{sub.*GLOBAL}}
 }
----------------
chandlerc wrote:
> Tiny nit pick: you can often narrow the scope of the regex, and I often find that easier to read. So I would usually write:
> 
>   ; CHECK-NOT: sub{{.*}}GLOBAL
Note taken, thanks!


https://reviews.llvm.org/D29807





More information about the llvm-commits mailing list