[PATCH] D30036: [JumpThreading] Re-enable JumpThreading for guards

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 12:01:07 PST 2017


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM!  I'll check this in for you once you address the minor stylistic comment mentioned inline.



================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:2076
+  // TODO: Look up deeper than to immediate predecessor?
+  auto Parent = Pred1->getSinglePredecessor();
+  if (!Parent || Parent != Pred2->getSinglePredecessor())
----------------
LLVM coding style is to use `auto *` for pointers.


https://reviews.llvm.org/D30036





More information about the llvm-commits mailing list