[PATCH] D29816: [X86][GlobalISel] Initial implementation , select G_ADD gpr, gpr

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM in general. Should you also add tests for s64?



================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:57
+
+  llvm_unreachable("Unknown RegBank!");
+  return nullptr;
----------------
llvm_unreachable calls abort, you shouldn't need to return or break after it (here and everywhere else).


================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:129
+
+  if (I.getNumOperands() != I.getNumExplicitOperands()) {
+
----------------
This would look better as an assert.


Repository:
  rL LLVM

https://reviews.llvm.org/D29816