[PATCH] D29956: [LV] Remove constant-step restriction for vector phi creation

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 16 07:22:13 PST 2017


mssimpso added inline comments.


================
Comment at: test/Transforms/LoopVectorize/induction-step.ll:201
+  ret void
+}
----------------
mssimpso wrote:
> mkuper wrote:
> > Do we have a negative test-case showing we don't try anything stupid for loop-variant values?
> I'll add one.
Actually, we don't handle inductions with loop-variant steps at all (InductionDescriptor::isInductionPHI). So I'll probably change the patch to assert instead of checking for loop-invariance.


https://reviews.llvm.org/D29956





More information about the llvm-commits mailing list