[PATCH] D29672: [DebugInfo] Make legal and emit DW_OP_swap and DW_OP_xderef

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added a comment.

In https://reviews.llvm.org/D29672#669785, @aprantl wrote:

> Thanks!
>
> - please include testcases


Done.

> - there probably needs to be a Verifier change as well

Isn't Verifier calling `DIExpression::isValid()`?

> As you probably noticed the other binary operators (like DW_OP_plus) are currently accepting their RHS argument as an "argument" rather than using the top-of-stack (-1). I consider this a bug, so I'm fine with these new operators behaving the way they are (using the stack) in this patch.

Do you know if there is bugzilla for it or if someone is working on fixing this bug?

Thanks.


https://reviews.llvm.org/D29672