[PATCH] D29925: Implement intrinsic mangling for literal struct types.Fixes PR 31921

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D29925#677860, @dberlin wrote:

> Okay,so i tried this on large bc files (all of clang, etc) i have around.
>
> The amount of time spent in remangling is almost not measureable.
>  For clang, it claims 100 microseconds.
>  I'm not sure it has that kind of measurement accuracy, but i can't find a large testcase where i can measure any real amount of time spent here.
>
> So i'm going to commit this, but we should definitely revert and try to focus it more if we do find a testcase that matters.


This sounds great to me. I like the numbers you found (IE, it is doing work, but the work doesn't seem to consume enough time).

LGTM!


https://reviews.llvm.org/D29925