[PATCH] D28957: Fix incorrect formatting of DataRefImpl members in operator<< function

[Dave Bozier via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
davidb marked 3 inline comments as done.
Closed by commit rL295173: Fix incorrect formatting of DataRefImpl members in operator<< function (authored by davidb).

Changed prior to commit:
  https://reviews.llvm.org/D28957?vs=85149&id=88513#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D28957

Files:
  llvm/trunk/include/llvm/Object/SymbolicFile.h
  llvm/trunk/unittests/Object/CMakeLists.txt
  llvm/trunk/unittests/Object/SymbolicFileTest.cpp


Index: llvm/trunk/include/llvm/Object/SymbolicFile.h
===================================================================
--- llvm/trunk/include/llvm/Object/SymbolicFile.h
+++ llvm/trunk/include/llvm/Object/SymbolicFile.h
@@ -16,6 +16,7 @@
 
 #include "llvm/Object/Binary.h"
 #include "llvm/Support/Format.h"
+#include <cinttypes>
 #include <utility>
 
 namespace llvm {
@@ -33,7 +34,8 @@
 
 template <typename OStream>
 OStream& operator<<(OStream &OS, const DataRefImpl &D) {
-  OS << "(" << format("0x%x8", D.p) << " (" << format("0x%x8", D.d.a) << ", " << format("0x%x8", D.d.b) << "))";
+  OS << "(" << format("0x%08" PRIxPTR, D.p) << " (" << format("0x%08x", D.d.a)
+     << ", " << format("0x%08x", D.d.b) << "))";
   return OS;
 }
 
Index: llvm/trunk/unittests/Object/SymbolicFileTest.cpp
===================================================================
--- llvm/trunk/unittests/Object/SymbolicFileTest.cpp
+++ llvm/trunk/unittests/Object/SymbolicFileTest.cpp
@@ -0,0 +1,34 @@
+//===- SymbolicFileTest.cpp - Tests for SymbolicFile.cpp ------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/Object/SymbolicFile.h"
+#include "llvm/Support/raw_ostream.h"
+#include "gtest/gtest.h"
+#include <sstream>
+
+TEST(Object, DataRefImplOstream) {
+  std::string s;
+  llvm::raw_string_ostream OS(s);
+  llvm::object::DataRefImpl Data;
+  Data.d.a = 0xeeee0000;
+  Data.d.b = 0x0000ffff;
+
+  static_assert(sizeof Data.p == sizeof(uint64_t) ||
+                    sizeof Data.p == sizeof(uint32_t),
+                "Test expected pointer type to be 32 or 64-bit.");
+
+  char const *Expected = sizeof Data.p == sizeof(uint64_t)
+                             ? "(0xffffeeee0000 (0xeeee0000, 0x0000ffff))"
+                             : "(0xeeee0000 (0xeeee0000, 0x0000ffff))";
+
+  OS << Data;
+  OS.flush();
+
+  EXPECT_EQ(Expected, s);
+}
Index: llvm/trunk/unittests/Object/CMakeLists.txt
===================================================================
--- llvm/trunk/unittests/Object/CMakeLists.txt
+++ llvm/trunk/unittests/Object/CMakeLists.txt
@@ -4,5 +4,6 @@
 
 add_llvm_unittest(ObjectTests
   SymbolSizeTest.cpp
+  SymbolicFileTest.cpp
   )
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28957.88513.patch
Type: text/x-patch
Size: 2409 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170215/c5b9f652/attachment-0001.bin>