[PATCH] D29948: [AMDGPU] Restructure runtime metadata creation

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPURuntimeMetadata.h:39
 
+namespace llvm {
 namespace AMDGPU {
----------------
yaxunl wrote:
> This header file is shared between runtime and compiler. It may not be proper to use namespace llvm here.
> 
> Also, changes to this file requires corresponding changes in runtime. Are the runtime changes in place?
I will probably switch away from llvm namespace here. I will update opencl runtime during the merge if needed.


https://reviews.llvm.org/D29948