[PATCH] D29929: [ELF] - Do not segfault when using -r and section groups.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 08:33:35 PST 2017


Sorry, I didn't realize that *current* gnu as has this bug :-(

Could you report a bug with them? I think the relevant ELF spec part is:

--------------------------------------
 There may not be non-symbol references to the sections comprising a group from outside the group, for example, use of a group member's section header index in an sh_link or sh_info member. 
----------------------------

> Index: test/ELF/relocation-group.test
> ===================================================================
> --- test/ELF/relocation-group.test
> +++ test/ELF/relocation-group.test
> @@ -0,0 +1,36 @@
> +# RUN: yaml2obj %s -o %t.o

Please add a comment saying what this corresponds to in asm and that the
gas output looks like this.


LGTM with the comment.

Thanks,
Rafael


More information about the llvm-commits mailing list