[PATCH] D27751: [LLVM] Use after move bug fixes

[Martin Böhme via Phabricator via llvm-commits]

mboehme added a comment.

What's the status of this change in general? There seem to be a couple of comments that are still open?



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:27000
   while (Mask.size() > 1 && canWidenShuffleElements(Mask, WidenedMask)) {
+    // No use after move, WidenMask reinitialized in canWidenShuffleElements.
     Mask = std::move(WidenedMask);
----------------
Prazek wrote:
> Prazek wrote:
> > mboehme wrote:
> > > Prazek wrote:
> > > > mboehme wrote:
> > > > > Typo: Should be WidenedMask
> > > > btw, why it fires here? It is passed to canWidenShuffleElements by reference and documentation says that it assumes it is being reinitialized in this case.
> > > You're right, it shouldn't fire here. I'll take a look at what's going wrong here.
> > I was also surprised. Thanks Martin for taking care about it
> have you checked this one Martin?
Sorry, no -- I've been busy with other things.


https://reviews.llvm.org/D27751