[llvm] r295051 - [X86][SSE] Tidyup matchVectorShuffleWithUNPCK helper function call.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 14 04:54:39 PST 2017


Author: rksimon
Date: Tue Feb 14 06:54:39 2017
New Revision: 295051

URL: http://llvm.org/viewvc/llvm-project?rev=295051&view=rev
Log:
[X86][SSE] Tidyup matchVectorShuffleWithUNPCK helper function call.

Don't bother setting the V1/V2 operands again for unary shuffles.

Don't bother legalizing the value type unless the match succeeds.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=295051&r1=295050&r2=295051&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Feb 14 06:54:39 2017
@@ -26608,15 +26608,11 @@ static bool matchBinaryVectorShuffle(MVT
       (MaskVT.is256BitVector() && 32 <= EltSizeInBits && Subtarget.hasAVX()) ||
       (MaskVT.is256BitVector() && Subtarget.hasAVX2()) ||
       (MaskVT.is512BitVector() && Subtarget.hasAVX512())) {
-    MVT LegalVT = MaskVT;
-    if (LegalVT.is256BitVector() && !Subtarget.hasAVX2())
-      LegalVT = (32 == EltSizeInBits ? MVT::v8f32 : MVT::v4f64);
-
     if (matchVectorShuffleWithUNPCK(MaskVT, V1, IsUnary ? V1 : V2, Shuffle,
                                     IsUnary, Mask)) {
-      if (IsUnary)
-        V2 = V1;
-      ShuffleVT = LegalVT;
+      ShuffleVT = MaskVT;
+      if (ShuffleVT.is256BitVector() && !Subtarget.hasAVX2())
+        ShuffleVT = (32 == EltSizeInBits ? MVT::v8f32 : MVT::v4f64);
       return true;
     }
   }




More information about the llvm-commits mailing list