[PATCH] D23563: [RISCV 6/10] Add basic RISCVAsmParser

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 21:56:39 PST 2017


asb added inline comments.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:78-81
+  struct TokOp {
+    const char *Data;
+    unsigned Length;
+  };
----------------
majnemer wrote:
> Isn't this just a `StringRef`?
Yes, I've replaced it with a StringRef now - thanks.


https://reviews.llvm.org/D23563





More information about the llvm-commits mailing list