[PATCH] D29919: allow migrating away from cmake option for LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 18:00:06 PST 2017


mehdi_amini added a comment.

Adding @bruno to check on the module story here, I'm still not sure what is or isn't reasonable to do with modules!

Otherwise LGTM.



================
Comment at: llvm/Config/abi-breaking.h.cmake:22
 #cmakedefine01 LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING
+#endif
 #if !LLVM_DISABLE_ABI_BREAKING_CHECKS_ENFORCING
----------------
It took me some time to figure out the logic here. But as long as it's temporary.


https://reviews.llvm.org/D29919





More information about the llvm-commits mailing list