[PATCH] D29865: [PDSE] Add a no-op pass.

[Daniel Berlin via llvm-commits]

On Mon, Feb 13, 2017 at 4:08 PM, bryant via Phabricator <
reviews at reviews.llvm.org> wrote:

> bryant marked 3 inline comments as done.
> bryant added inline comments.
>
>
> ================
> Comment at: lib/Transforms/Scalar/PDSE.cpp:59
> +// (resp. post-dominate) their successor (resp. predecessor) blocks
> (SSAPRE
> +// assumes this condition).
> +
> ----------------
> > This TODO really belongs here or you can throw it away?
>
> SSAPRE (resp. PDSE) needs critical edges to be broken in order for
> down-unsafety (resp. up-unsafety) propagation to be correct.


FWIW:This is fixable.

>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170213/351cd040/attachment.html>