[PATCH] D29265: [legalize-types] Remove stale entries from SoftenedFloats.

Chih-Hung Hsieh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 13 15:14:03 PST 2017


chh added a comment.

In https://reviews.llvm.org/D29180, I saw that fp16.ll was changed to run with -enable-legalize-types-checking. Could you add extra test runs with the -enable-legalize-types-checking flag, into current fp128 tests and some other tests depending on SoftenedFloats? Then some of those runs will pass only if this change to LegalizeTypes.cpp is applied, right?

Although I am not sure about the impact of this change to all SoftenedFloats targets, at least I have not seen regression in my local simple Android x86-64 build test. I hope someone else more familiar with this module can review this change. Thanks.


https://reviews.llvm.org/D29265





More information about the llvm-commits mailing list