[llvm] r294885 - [lib/LTO] Add support for hotness optremarks in the new API.

[Teresa Johnson via llvm-commits]

Minor typo to fix noted below.
Thanks,
Teresa

On Sat, Feb 11, 2017 at 9:05 PM, Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: davide
> Date: Sat Feb 11 23:05:35 2017
> New Revision: 294885
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294885&view=rev
> Log:
> [lib/LTO] Add support for hotness optremarks in the new API.
>
> Added:
>     llvm/trunk/test/LTO/Resolution/X86/diagnostic-
> handler-remarks-with-hotness.ll
> Modified:
>     llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp
>
> Added: llvm/trunk/test/LTO/Resolution/X86/diagnostic-
> handler-remarks-with-hotness.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/
> Resolution/X86/diagnostic-handler-remarks-with-hotness.
> ll?rev=294885&view=auto
> ============================================================
> ==================
> --- llvm/trunk/test/LTO/Resolution/X86/diagnostic-
> handler-remarks-with-hotness.ll (added)
> +++ llvm/trunk/test/LTO/Resolution/X86/diagnostic-
> handler-remarks-with-hotness.ll Sat Feb 11 23:05:35 2017
> @@ -0,0 +1,37 @@
> +; RUN: llvm-as < %s >%t.bc
> +
> +; RUN: rm -f %t.yaml
> +; RUN: llvm-lto2 -pass-remarks-output=%t.yaml \
> +; RUN:           -pass-remarks-with-hotness \
> +; RUN:           -r %t.bc,tinkywinky,p \
> +; RUN:           -r %t.bc,patatino,px \
> +; RUN:           -r %t.bc,main,px -o %t.o %t.bc
> +; RUN: cat %t.yaml | FileCheck %s -check-prefix=YAML
> +
> +; YAML: --- !Passed
> +; YAML-NEXT: Pass:            inline
> +; YAML-NEXT: Name:            Inlined
> +; YAML-NEXT: Function:        main
> +; YAML-NEXT: Hotness:         300
> +; YAML-NEXT: Args:
> +; YAML-NEXT:   - Callee:          tinkywinky
> +; YAML-NEXT:   - String:          ' inlined into '
> +; YAML-NEXT:   - Caller:          main
> +; YAML-NEXT: ...
> +
> +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> +target triple = "x86_64-scei-ps4"
> +
> +declare i32 @patatino()
> +
> +define i32 @tinkywinky() {
> +  %a = call i32 @patatino()
> +  ret i32 %a
> +}
> +
> +define i32 @main() !prof !0 {
> +  %i = call i32 @tinkywinky()
> +  ret i32 %i
> +}
> +
> +!0 = !{!"function_entry_count", i64 300}
>
> Modified: llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-
> lto2/llvm-lto2.cpp?rev=294885&r1=294884&r2=294885&view=diff
> ============================================================
> ==================
> --- llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp (original)
> +++ llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp Sat Feb 11 23:05:35 2017
> @@ -94,6 +94,11 @@ static cl::opt<std::string>
>      OptRemarksOutput("pass-remarks-output",
>                       cl::desc("YAML output file for optimization
> remarks"));
>
> +static cl::opt<bool> OptRemarksWithsHotness(
>

Typo here and in use below: "Withs".
Teresa


> +    "pass-remarks-with-hotness",
> +    cl::desc("Whether to include hotness informations in the remarks.\n"
> +             "Has effect only if -pass-remarks-output is specified."));
> +
>  static void check(Error E, std::string Msg) {
>    if (!E)
>      return;
> @@ -182,6 +187,7 @@ int main(int argc, char **argv) {
>
>    // Optimization remarks.
>    Conf.RemarksFilename = OptRemarksOutput;
> +  Conf.RemarksWithHotness = OptRemarksWithsHotness;
>
>    // Run a custom pipeline, if asked for.
>    Conf.OptPipeline = OptPipeline;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170213/5c2a37b7/attachment.html>