[PATCH] D29789: [MC] Set SHT_MIPS_DWARF section type for all .debug_* sections on MIPS

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

This patch appears to be missing the declaration for SHT_MIPS_DWARF = 0x7000001e in include/llvm/Support/ELF.h.

One comment request inlined.



================
Comment at: lib/MC/MCObjectFileInfo.cpp:508
 
+  unsigned DebugSecType = ELF::SHT_PROGBITS;
+  if (T.getArch() == Triple::mips || T.getArch() == Triple::mipsel ||
----------------
This hunk could probably do with a comment noting that it is historical behaviour / an extension to DWARF-2 for MIPS to mark debug sections with SHT_MIPS_DWARF rather than the usual SHT_PROGBITS.


Repository:
  rL LLVM

https://reviews.llvm.org/D29789