[PATCH] D29870: [InlineCost] Increase the cost of Switch

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

The basic reasoning makes sense to me when we do the binary search lowering. However, while you talk about simplify-cfg handling the lookup table case, this code should also respond well to the case where it will be lowered as a jump table.

Beyond that, this needs to be accompanied by basic code size and runtime benchmark numbers for the LLVM test suite. It would be nice to also check SPEC.

If you can't benchmark enough platforms, it may make sense to ask other LLVM users to benchmark this (either in patch form or by changing the patch to put this behind a flag at first) so that we can collect their data.


Repository:
  rL LLVM

https://reviews.llvm.org/D29870