[PATCH] D29861: ELF: Read all dynamic lists specified on the command line.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 11 09:20:18 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/LinkerScript.cpp:1945-1946
       expect(":");
-    Config->VersionScriptGlobals = readSymbols();
+    std::vector<SymbolVersion> Globals = readSymbols();
+    for (SymbolVersion V : Globals)
+      Config->VersionScriptGlobals.push_back(V);
----------------
Can this be `for (SymbolVersion V : readSymbols())`?


https://reviews.llvm.org/D29861





More information about the llvm-commits mailing list