[llvm] r294789 - [LTO] Make these tests robust across multiple iterations.

Yung, Douglas via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 14:53:06 PST 2017


Hi Davide, I don't know if you are aware, but this checkin as well as r294784 caused the tests you changed to fail on the Windows PS4 bot. The problem is that the rm command that you added with "*" gives an error on Windows if nothing matches (there is nothing to delete). Can you fix the tests?

r294784:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5279

r294789:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5282

Douglas Yung

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf Of
> Davide Italiano via llvm-commits
> Sent: Friday, February 10, 2017 14:11
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r294789 - [LTO] Make these tests robust across multiple
> iterations.
> 
> Author: davide
> Date: Fri Feb 10 16:11:06 2017
> New Revision: 294789
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=294789&view=rev
> Log:
> [LTO] Make these tests robust across multiple iterations.
> 
> Same as r294784, but for regular LTO.
> 
> Modified:
>     llvm/trunk/test/LTO/X86/diagnostic-handler-remarks-with-hotness.ll
>     llvm/trunk/test/LTO/X86/diagnostic-handler-remarks.ll
> 
> Modified: llvm/trunk/test/LTO/X86/diagnostic-handler-remarks-with-hotness.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/X86/diagnostic-
> handler-remarks-with-hotness.ll?rev=294789&r1=294788&r2=294789&view=diff
> ==============================================================================
> --- llvm/trunk/test/LTO/X86/diagnostic-handler-remarks-with-hotness.ll
> (original)
> +++ llvm/trunk/test/LTO/X86/diagnostic-handler-remarks-with-hotness.ll Fri Feb
> 10 16:11:06 2017
> @@ -2,6 +2,7 @@
>  ; with -lto-pass-remarks-with-hotness.
> 
>  ; RUN: llvm-as < %s >%t.bc
> +; RUN: rm -f %t.yaml*
>  ; RUN: llvm-lto -lto-pass-remarks-output=%t.yaml \
>  ; RUN:          -lto-pass-remarks-with-hotness \
>  ; RUN:          -exported-symbol _func2 \
> 
> Modified: llvm/trunk/test/LTO/X86/diagnostic-handler-remarks.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/X86/diagnostic-
> handler-remarks.ll?rev=294789&r1=294788&r2=294789&view=diff
> ==============================================================================
> --- llvm/trunk/test/LTO/X86/diagnostic-handler-remarks.ll (original)
> +++ llvm/trunk/test/LTO/X86/diagnostic-handler-remarks.ll Fri Feb 10 16:11:06
> 2017
> @@ -28,6 +28,7 @@
>  ; RUN: llvm-nm %t.o | FileCheck %s -check-prefix NM
> 
>  ; Optimization records are collected regardless of the diagnostic handler
> +; RUN: rm -f %t.yaml*
>  ; RUN: llvm-lto -lto-pass-remarks-output=%t.yaml \
>  ; RUN:          -exported-symbol _func2 \
>  ; RUN:          -exported-symbol _main -o %t.o %t.bc 2>&1 | \
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list