[PATCH] D29717: [LoopVectorize] Added address space check when analysing interleaved accesses

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 10 14:52:45 PST 2017


mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D29717#674077, @efriedma wrote:

> Sorry I wasn't clear.  You should check the address spaces of pointers before passing them to getMinusSCEV because the operands of getMinusSCEV are required to have the same bit-width.  So this patch is correct as-is.


Pointers in different address spaces may or may not have different bitwidths. Will getMinusSCEV assert if the pointers are in different address spaces but have the same bitwidth? And what's the right behavior?

In any case, that's mostly academic. This LGTM.


https://reviews.llvm.org/D29717





More information about the llvm-commits mailing list