[PATCH] D29717: [LoopVectorize] Added address space check when analysing interleaved accesses

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added a comment.

This looks good to me (aside from a very minor nit about the test run line). Please give Michael and Eli a chance to respond to your questions, though.



================
Comment at: test/Transforms/LoopVectorize/AArch64/pr31900.ll:1
+; RUN: opt -mtriple=aarch64-apple-ios -loop-vectorize -enable-interleaved-mem-accesses -o /dev/null %s
+
----------------
Ka-Ka wrote:
> mssimpso wrote:
> > I would prefer that we actually check the resulting IR rather than checking for "no crash". Maybe force vectorization (-force-vector-width) and then check that the loads are scalarized.
> Sure, I will update the testcase in the next patch.
For the run line, we don't need the "-o -", and we now usually input from stdin like "< %s".  I think this may make testing faster, but I'm not sure.


https://reviews.llvm.org/D29717