[PATCH] D29452: AMDGPU/SI: DAGMutation for removing deps between CSEs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In https://reviews.llvm.org/D29452#673739, @tstellar wrote:

> In https://reviews.llvm.org/D29452#673738, @arsenm wrote:
>
> > Should this try to delete the redundant moves itself? MachineCSE runs earlier on SSA, so this isn't getting cleaned up. It helps with the clustering, but I get sequences of re-initing m0 to -1 like:
>
>
> I tried to have the DAGMutation delete the redundant moves, but I started getting assertion failures all over (maybe you can get this to work, not sure).  Might have to just run MachineCSE after scheduling.


I would be somewhat surprised if the scheduler allowed deleting instructions, I doubt anywhere else does this


https://reviews.llvm.org/D29452