[PATCH] D29742: [XRay] Implement powerpc64le xray.

[Tim Shen via Phabricator via llvm-commits]

timshen marked an inline comment as done.
timshen added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1136
+  case TargetOpcode::PATCHABLE_RET:
+    llvm_unreachable("");
+  }
----------------
echristo wrote:
> dberris wrote:
> > Probably want a friendly/informative message saying why this ought to be unreachable -- does the codegen not disambiguate tail calls and patchable returns?
> +1
Sorry, I didn't mean to leave it empty... sometimes when I turn a poc into a real patch I miss things. :P


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:68
 PPCInstrInfo::PPCInstrInfo(PPCSubtarget &STI)
-    : PPCGenInstrInfo(PPC::ADJCALLSTACKDOWN, PPC::ADJCALLSTACKUP),
+    : PPCGenInstrInfo(PPC::ADJCALLSTACKDOWN, PPC::ADJCALLSTACKUP, -1,
+                      STI.isPPC64() ? PPC::BLR8 : PPC::BLR),
----------------
echristo wrote:
> -1? Can you make this a bit more descriptive? :)
Added a block comment indicating the parameter. It's default-initialized to -1 if I don't manually initialize it. I have to, however, manually initialize it, because of our lovely C++ default-argument rules.


https://reviews.llvm.org/D29742