[PATCH] D29759: [SCEV] Cache results during GetMinTrailingZeros query

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm, but please make the `Impl` a private member function of `ScalarEvolution`.



================
Comment at: lib/Analysis/ScalarEvolution.cpp:4440
 
-uint32_t
-ScalarEvolution::GetMinTrailingZeros(const SCEV *S) {
+static uint32_t GetMinTrailingZerosImpl(const SCEV *S, ScalarEvolution &SE,
+                                        AssumptionCache &AC,
----------------
Extracting out the `Impl` function as a static function is somewhat odd -- why did you just keep it as a normal member function?


https://reviews.llvm.org/D29759