[PATCH] D29309: [PM] Add support for instrumented PGO in the new pass manager (clang-side)

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

FWIW, this all looks good on my end. David, does this address your concern?



================
Comment at: lib/CodeGen/BackendUtil.cpp:63-65
 
+// Default filename used for profile generation.
+static constexpr StringLiteral DefaultProfileGenName = "default_%m.profraw";
----------------
davide wrote:
> davide wrote:
> > FWIW, this was part of `AssemblyHelper` initially.
> > I thought that worked, instead I got a linker error (undefined reference to etc..)
> > I can't claim to be a C++ expert so I asked @Bigcheese and he pointed out this could actually be a bug in clang.
> Just for the records, not a clang bug, it's missing an out-of-line def (thanks zygoloid for pointing out)
As discussed in IRC, looks like we know how to sink this into the class now.


https://reviews.llvm.org/D29309