[PATCH] D28499: SimplifyLibCalls: Replace copysign calls with intrinsic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In https://reviews.llvm.org/D28499#664916, @arsenm wrote:

> In https://reviews.llvm.org/D28499#664355, @hfinkel wrote:
>
> > I think that most of this looks good, except as noted below...
>
>
>
>
> In https://reviews.llvm.org/D28499#664355, @hfinkel wrote:
>
> > I think that most of this looks good, except as noted below...
>
>
> I only did this to keep what it was already doing for the libcall. Should I just rip out all of those tests and drop this?


DAGCombiner does something similar and more interesting because it can mismatch the source types.

If I drop this all of the interesting tested cases work if I drop that part, except for test19 in float-shrink-compare (added by https://reviews.llvm.org/D6495, which apparently was a reported bug). I could special case this in the fcmp handling


https://reviews.llvm.org/D28499