[PATCH] D29807: FileCheck-ize some tests in test/CodeGen/X86/

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 19:11:58 PST 2017


chandlerc added a comment.

In https://reviews.llvm.org/D29807#673088, @jgorbe wrote:

> Forgot to add llvm-commits, commenting so a message gets posted there. Sorry!


Sure, looking at this now.

Just as an FYI for the future, it is a bit nicer to just abandon a revision when you miss llvm-commits at first, and post a fresh one. That way Phabricator attaches a patch file for folks who want to do the code review via email.


https://reviews.llvm.org/D29807





More information about the llvm-commits mailing list