[PATCH] D29752: [libFuzzer] Export external functions.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 14:15:00 PST 2017


kcc added a comment.

No, I don't agree with this change. 
First, FuzzerInterface.h must not depend on any other header. 
Second, I don't want the tests depend on "FuzzerInterface.h"

I realize this is not in accordance to C++ best practices and I don't know how long
we'll be able to have fuzz targets not include any headers like "FuzzerInterface.h". 
But I want to keep things as they are for now.

The main rationale here: the fuzz targest must be completely independent from the fuzz engines and the interface must be very thin.

Feel free to disable the tests on windows with a comment describing the problem and pointing to this review.


https://reviews.llvm.org/D29752





More information about the llvm-commits mailing list