[PATCH] D29775: [LLD] Add memory ORIGIN and LENGTH expression support

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1871
+    StringRef Name = readParenLiteral();
+    return { [=](uint64_t Dot) { return ScriptConfig->MemoryRegions[Name].Origin; } };
+    }
----------------
Is this guaranteed that MemoryRegion[Name] exists?


================
Comment at: ELF/LinkerScript.cpp:1872
+    return { [=](uint64_t Dot) { return ScriptConfig->MemoryRegions[Name].Origin; } };
+    }
+  if (Tok == "LENGTH") {
----------------
Fix indentation


================
Comment at: ELF/LinkerScript.cpp:1876
+    return { [=](uint64_t Dot) { return ScriptConfig->MemoryRegions[Name].Length; } };
+    }
 
----------------
Ditto


================
Comment at: test/ELF/linkerscript/symbol-memoryexpr.s:25
+ nop
\ No newline at end of file

----------------
Please add a newline at end.


https://reviews.llvm.org/D29775