[PATCH] D29728: Remove strict tid checks from the mac implementation of BlockingMutex

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 10:16:41 PST 2017


dvyukov added a comment.

Do you have commit access? Or you want me to commit after the comment move?



================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:359
 
+// This function explicitly avoids checking whether the mutex is owned by
+// the calling thread. This behavior, while more strictly correct, causes
----------------
Sorry I meant comment on _declaration of the function.
This implementation is now not different from other implementations, so it does not make sense to have it here. Also a linux, or windows developers does not necessary read comments in _mac files, so he/she can change, say, windows implementation tomorrow to do the stricter check.


https://reviews.llvm.org/D29728





More information about the llvm-commits mailing list