[PATCH] D29765: Handle link of NoDebug CU with a CU that has debug emission enabled

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 9 09:26:38 PST 2017


dblaikie added a comment.

Superficially (I haven't looked at all the codepaths, etc) the code change looks OK.

Testing could probably be a lot simpler - can you take the merged IR and test that, rather than running LTO steps in the test? It seems the resulting IR is what we want to test/what's being fixed, not the path that was used to reach it.


https://reviews.llvm.org/D29765





More information about the llvm-commits mailing list