[PATCH] D28249: Improve scheduling with branch coalescing

[Kit Barton via Phabricator via llvm-commits]

kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

Aside from a couple minor comments, this LGTM.

It would be good if @hfinkel or @echristo could take a look also.



================
Comment at: lib/CodeGen/BranchCoalescing.cpp:119
+///
+/// Branch Coalesce does not split blocks, it moves everything in the same
+/// direction ensuring it does not break use/definition semantics.
----------------
Branch Coalescing not Branch Coalesce


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:753
+  if (didSomething)
+    MF.verify(nullptr, "Error in code produced by branch coalescing");
+#endif // NDEBUG
----------------
Did we conclude whether this is different from the checks done by the verifyAfter parameter in addPass?


https://reviews.llvm.org/D28249