[PATCH] D29700: [AMDGPU] Implement register pressure callbacks

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 10:47:56 PST 2017


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIRegisterInfo.h:275
+  unsigned getRegPressureLimit(const TargetRegisterClass *RC,
+                               MachineFunction &MF) const override;
+
----------------
rampitec wrote:
> arsenm wrote:
> > const should be added here instead of using const_cast from the other overload?
> There is no prototype with const MF. Too bad.
Note, even if I implement my own function taking const MF and call it from non-const overload, the const_cast will just move into that function to call parent's getRegPressureLimit().


Repository:
  rL LLVM

https://reviews.llvm.org/D29700





More information about the llvm-commits mailing list