[PATCH] D28922: [LoadCombine] Fix combining of loads which span an aliasing store.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: test/Transforms/LoadCombine/load-combine-aa.ll:48
+; CHECK: load i16, i16*
+; CHECK: store i16
+; CHECK: ret i16
----------------
Ka-Ka wrote:
> efriedma wrote:
> > Check for the second load after the store?
> The testcase run first the load-combine pass and then instcombine pass. The instcombine pass will remove the second load after the store. If you think it is important to check for the second load then the testcase need to be splitted from the other tests and the instcombine pass need to be turned off.
> 
Probably the whole file should be fixed not to run instcombine.


https://reviews.llvm.org/D28922