[PATCH] D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:133
+    lib_clang_dir = "\\".join([Property("builddir"), config, "lib", "clang"])
+    f.addStep(SetProperty(name="get clang version",
+                          command=["dir", "/b", lib_clang_dir],
----------------
This might fail if many version of clang have been built and the lib directory contains more than one version. I suspect the bot already has more than one version directory.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:140
+    # Get binary dir.
+    bin_path = "\\".join([Property("builddir"), config, "bin"])
+    # Get compiler-rt's libraries dir.
----------------
I doubt this will work. A "Property" is not a string or dictionary. The master never sees the property values until the build actually executes. It has to generate the list of steps to execute up front, before actually running any of them. When you say "addStep", that adds a step to be run in the future on another machine. The steps don't run synchronously inside this python code.

As an alternative, we don't need to set PATH if we link statically, right? I'd recommend we do that. Set "-DLLVM_USE_CRT_"+config.upper()"=MT" in the cmake command to do that.


https://reviews.llvm.org/D29677