[PATCH] D29664: [LLD][ELF] Refactor PltSection and IPltSection common code into a base class NFC

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 07:12:05 PST 2017


Peter Smith via Phabricator <reviews at reviews.llvm.org> writes:

> peter.smith updated this revision to Diff 87651.
> peter.smith added a comment.
>
> Updated the diff with an attempt to use a single class for both the Plt and IPlt. I've used HeaderSize to distinguish between them as that removes a few conditional statements.
>

I like it. LGTM, but please wait for Rui's opinion too.

Cheers,
Rafael


More information about the llvm-commits mailing list