[PATCH] D29715: LVI: Add a per-value worklist limit to LazyValueInfo.

Daniel Jasper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 8 06:40:39 PST 2017


djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.

lg



================
Comment at: lib/Analysis/LazyValueInfo.cpp:661
+    // Because of the design of the overdefined cache currently being per-block
+    // to avoid naming related issues (IE it wants to try to give different
+    // results for the same name in different blocks), overdefined results don't
----------------
nit: naming-related.


================
Comment at: lib/Analysis/LazyValueInfo.cpp:668
+    if (processedCount > MaxProcessedPerValue) {
+      errs() << "Giving up on stack because we are getting too deep\n";
+      // Fill in the original values
----------------
Have you intentionally changed this from DEBUG(dbgs() << ..)?


https://reviews.llvm.org/D29715





More information about the llvm-commits mailing list