[PATCH] D29373: NVPTX: Extract mem intrinsic expansions into utilities

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked 5 inline comments as done.
arsenm added inline comments.


================
Comment at: include/llvm/Transforms/Utils/LowerMemIntrinsics.h:40
+                          unsigned SrcAlign, unsigned DestAlign,
+                          bool SrcIsVolatile, bool DstIsVolatile);
+void convertMemMoveToLoop(MemMoveInst *MemMove);
----------------
jlebar wrote:
> jlebar wrote:
> > Do we really need these utilities for creating memmov and memset loops?  I guess they're kind of useful, but if nobody is using them our code isn't tested or anything, so maybe it's better to leave them out for now?
> If you wanted, you could keep these functions as file-private in the cc file.  This way if we ever want to make them public, it's straightforward.
I only left these because the NVPTX pass uses the memcpy function for the questionable handling of aggregate copies, and then kept it the same for the others. I can make them private.


https://reviews.llvm.org/D29373