[PATCH] D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 17:18:45 PST 2017


rnk added inline comments.


================
Comment at: zorg/buildbot/builders/SanitizerBuilderWindows.py:128
+    bin_path = os.path.join(config_path, "bin")
+    dll_path = glob.glob(config_path + "\lib\clang\*\lib\windows")[0]
+    clang_cl = os.path.join(bin_path, "clang-cl")
----------------
zturner wrote:
> The backslashes here need to be escaped or they will be treated as escape characters.  Or use `path.join` so you don't have to deal with slashes at all.
This won't work, this code will execute on the master, not the build slave, so the CWD will be wrong, and we won't be able to glob. I think it might be possible to construct a relative path to clang-cl, but I'm not sure how to add the absolute runtime library path to PATH.


https://reviews.llvm.org/D29677





More information about the llvm-commits mailing list