[PATCH] D29689: [ELF] Handle output section alignment in linker scripts

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 7 15:01:34 PST 2017


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:372
+
+      if (Cmd->AlignExpr) {
+        uint32_t Align = Cmd->AlignExpr(0);
----------------
I don't know if this is the right place to add this code. Have all output sections been created when the control reaches here? I think LinkerScript<ELFT>::assignOffsets is a better place to do this.


Repository:
  rL LLVM

https://reviews.llvm.org/D29689





More information about the llvm-commits mailing list